daemon: Trim cookie string

If the cookie file had a newline in it, the program would not work

Dockerfile

@@ -1,7 +1,7 @@
 ##################
 ### BASE STAGE ###
 ##################
-FROM rust:1.53 as base
+FROM rust:1.56 as base
 
 # Install build dependencies
 RUN cargo install strip_cargo_version

cli/Cargo.toml

@@ -1,9 +1,9 @@
 [package]
 name = "stl_cli"
-version = "2.6.6"
+version = "2.6.8"
 authors = ["Joakim Hulthe <joakim@hulthe.net>"]
 license = "MPL-2.0"
-edition = "2018"
+edition = "2021"
 
 [[bin]]
 name = "stl"

cli/src/daemon.rs

@@ -18,29 +18,31 @@ use tokio::task::{spawn, JoinHandle};
 pub fn run(opt: DaemonOpt) -> Result<(), Error> {
     let opt: &'static DaemonOpt = Box::leak(Box::new(opt));
     let cookie: &'static str =
-        Box::leak(std::fs::read_to_string(&opt.cookie_file)?.into_boxed_str());
+        Box::leak(std::fs::read_to_string(&opt.cookie_file)?.into_boxed_str()).trim();
 
     let rt = Runtime::new()?;
     rt.block_on(async {
-        let (tx, rx) = mpsc::channel();
-
         info!("creating output file");
         fs::write(&opt.file, b"").await?;
 
+        // setup INotify watcher
+        let (tx, rx) = mpsc::channel();
         let mut watcher = INotifyWatcher::new_raw(tx).unwrap();
         watcher
             .watch(&opt.file, RecursiveMode::NonRecursive)
             .expect("failed to watch file");
+        let mut inotify = proxy_channel(rx);
 
+        // perform first category update
         soft_fail(update_category_list(opt, cookie).await);
         let mut last_update = Instant::now();
 
-        let mut wfe: JoinHandle<_> = spawn(wait_for_event(opt, cookie));
-
-        let mut rx = proxy_channel(rx);
+        // start WFE long-poll
+        let mut wfe_handle: Option<JoinHandle<_>> = Some(spawn(wait_for_event(opt, cookie)));
 
         loop {
-            let event = match rx.recv().await {
+            // wait for next inotify event
+            let event = match inotify.recv().await {
                 Some(event) => event,
                 None => return Err(Error::ChannelClosed),
             };
@@ -48,15 +50,17 @@ pub fn run(opt: DaemonOpt) -> Result<(), Error> {
             debug!("event op {:?}", event.op);
 
             match event.op {
-                Ok(Op::CHMOD) => { /* YEESSS */ }
+                Ok(Op::CHMOD) => { /* we only care about this event */ }
                 _ => continue,
             }
 
             debug!("CHMOD event detected");
 
-            let update_categories;
-            let restart_wfe;
-
+            // poll wfe and decide whether we want to restart it, and whether we want to update the
+            // categories
+            let restart_wfe: bool;
+            let update_categories: Option<bool>;
+            if let Some(mut wfe) = wfe_handle.take() {
                 match poll!(&mut wfe) {
                     Poll::Ready(Ok(Ok(_wfe))) => {
                         restart_wfe = true;
@@ -74,8 +78,15 @@ pub fn run(opt: DaemonOpt) -> Result<(), Error> {
                     Poll::Pending => {
                         restart_wfe = false;
                         update_categories = Some(false);
+
+                        // wfe task is not complete, we will continue waiting for it next loop
+                        wfe_handle = Some(wfe)
                     }
                 }
+            } else {
+                restart_wfe = false;
+                update_categories = None;
+            }
 
             let elapsed = last_update.elapsed();
             debug!(
@@ -94,13 +105,13 @@ pub fn run(opt: DaemonOpt) -> Result<(), Error> {
             }
 
             if update_categories || restart_wfe {
-                wfe = spawn(wait_for_event(opt, cookie));
+                wfe_handle = Some(spawn(wait_for_event(opt, cookie)));
             }
         }
     })
 }
 
-#[derive(Deserialize)]
+#[derive(Clone, Debug, Deserialize)]
 struct WaitForEvent {
     #[allow(dead_code)]
     timeout: bool,

lib/Cargo.toml

@@ -1,9 +1,9 @@
 [package]
 name = "stl_lib"
-version = "2.6.6"
+version = "2.6.8"
 authors = ["Joakim Hulthe <joakim@hulthe.net>"]
 license = "MPL-2.0"
-edition = "2018"
+edition = "2021"
 
 
 [dependencies]

server/Cargo.toml

@@ -1,10 +1,10 @@
 [package]
 name = "stl"
 description = "studielogg aka scuffed toggl"
-version = "2.6.6"
+version = "2.6.8"
 authors = ["Joakim Hulthe <joakim@hulthe.net>"]
 license = "MPL-2.0"
-edition = "2018"
+edition = "2021"
 
 [dependencies]
 dotenv = "0.13.0"
@@ -29,13 +29,9 @@ version = "1"
 features = ["sync", "time"]
 
 [dependencies.rocket]
-#version = "0.4"
-git = "https://github.com/SergioBenitez/Rocket"
-branch = "master"
-features = ["secrets"]
+version = "0.5.0-rc.1"
+features = ["secrets", "json", "uuid"]
 
-[dependencies.rocket_contrib]
-#version = "0.4"
-git = "https://github.com/SergioBenitez/Rocket"
-branch = "master"
-features = ["handlebars_templates", "uuid"]
+[dependencies.rocket_dyn_templates]
+version = "0.1.0-rc.1"
+features = ["handlebars"]

server/src/auth.rs

@@ -5,10 +5,10 @@ use rocket::{
     http::{Cookie, CookieJar, Status},
     post,
     request::{FromRequest, Outcome, Request},
-    response::Redirect,
+    response::{content::Html, Redirect},
     uri, State,
 };
-use rocket_contrib::templates::Template;
+use rocket_dyn_templates::Template;
 
 pub struct MasterPassword(String);
 impl From<String> for MasterPassword {
@@ -41,8 +41,8 @@ impl<'a> FromRequest<'a> for Authorized {
 }
 
 #[catch(401)]
-pub fn login_page(_req: &Request) -> Template {
-    Template::render("login", &())
+pub fn login_page(_req: &Request) -> Html<Template> {
+    Html(Template::render("login", &()))
 }
 
 #[derive(FromForm)]
@@ -54,7 +54,7 @@ pub struct Login {
 pub fn login(
     cookies: &CookieJar,
     login: Form<Login>,
-    master_pass: State<MasterPassword>,
+    master_pass: &State<MasterPassword>,
 ) -> Redirect {
     if login.password == master_pass.0 {
         cookies.add_private(Cookie::new(AUTH_COOKIE_KEY, AUTH_COOKIE_VAL));

server/src/handlebars_util.rs

@@ -1,6 +1,6 @@
 use chrono::{DateTime, Local};
 use handlebars::handlebars_helper;
-use rocket_contrib::templates::Engines;
+use rocket_dyn_templates::Engines;
 
 pub fn register_helpers(engines: &mut Engines) {
     handlebars_helper!(pretty_datetime: |dt: str| {

server/src/main.rs

@@ -14,8 +14,8 @@ use crate::util::EventNotifier;
 use bincode::{deserialize, serialize};
 use chrono::NaiveDate;
 use dotenv::dotenv;
-use rocket_contrib::serve::StaticFiles;
-use rocket_contrib::templates::Template;
+use rocket::fs::FileServer;
+use rocket_dyn_templates::Template;
 use std::{env, io};
 
 #[rocket::main]
@@ -47,7 +47,7 @@ async fn main() -> io::Result<()> {
                 SCHEMA_VERSION, prev_schema_version
             );
 
-            migrate(&mut sled, prev_schema_version, SCHEMA_VERSION).expect("Migration failed")
+            migrate(&mut sled, prev_schema_version, SCHEMA_VERSION).expect("migration failed")
         }
         None => {
             println!("Schema version: {}, previously: None", SCHEMA_VERSION);
@@ -64,7 +64,7 @@ async fn main() -> io::Result<()> {
         .manage(master_pass)
         .manage(birth_date)
         .manage(EventNotifier::new())
-        .mount("/static", StaticFiles::from("static"))
+        .mount("/static", FileServer::from("static"))
         .mount(
             "/",
             rocket::routes![

server/src/routes/api.rs

@@ -9,9 +9,9 @@ use chrono::{Duration, Local, NaiveDateTime, TimeZone};
 use rocket::form::{Form, FromForm};
 use rocket::http::Status;
 use rocket::response::Redirect;
+use rocket::serde::json::Json;
+use rocket::serde::uuid::Uuid;
 use rocket::{get, post, uri, State};
-use rocket_contrib::json::Json;
-use rocket_contrib::uuid::Uuid;
 use sled::Transactional;
 use stl_lib::wfe::WaitForEvent;
 
@@ -19,8 +19,8 @@ use stl_lib::wfe::WaitForEvent;
 pub fn start_session(
     _auth: Authorized,
     category_uuid: Uuid,
-    event_notifier: State<'_, EventNotifier>,
-    db: State<'_, sled::Db>,
+    event_notifier: &State<EventNotifier>,
+    db: &State<sled::Db>,
 ) -> Result<StatusJson, StatusJson> {
     toggle_category_session(category_uuid, true, event_notifier, db)
 }
@@ -29,8 +29,8 @@ pub fn start_session(
 pub fn end_session(
     _auth: Authorized,
     category_uuid: Uuid,
-    event_notifier: State<'_, EventNotifier>,
-    db: State<'_, sled::Db>,
+    event_notifier: &State<EventNotifier>,
+    db: &State<sled::Db>,
 ) -> Result<StatusJson, StatusJson> {
     toggle_category_session(category_uuid, false, event_notifier, db)
 }
@@ -38,12 +38,12 @@ pub fn end_session(
 pub fn toggle_category_session(
     category_uuid: Uuid,
     set_active: bool,
-    event_notifier: State<'_, EventNotifier>,
-    db: State<'_, sled::Db>,
+    event_notifier: &State<EventNotifier>,
+    db: &State<sled::Db>,
 ) -> Result<StatusJson, StatusJson> {
     use crate::database::latest::trees::{category, session};
 
-    let category_uuid_s = sled::IVec::from(serialize(&category_uuid.into_inner())?);
+    let category_uuid_s = sled::IVec::from(serialize(&category_uuid)?);
 
     let categories_tree = db.open_tree(category::NAME)?;
     let sessions_tree = db.open_tree(session::NAME)?;
@@ -63,7 +63,7 @@ pub fn toggle_category_session(
                             if duration > Duration::minutes(5) {
                                 let session_uuid = serialize(&uuid::Uuid::new_v4()).unwrap();
                                 let session = session::V {
-                                    category: category_uuid.into_inner(),
+                                    category: category_uuid,
                                     started,
                                     ended: now,
                                     deleted: category.deleted,
@@ -103,14 +103,14 @@ pub fn edit_session(
     _auth: Authorized,
     session_uuid: Uuid,
     session: Form<EditSession>,
-    db: State<'_, sled::Db>,
+    db: &State<sled::Db>,
 ) -> Result<Redirect, StatusJson> {
     use crate::database::latest::trees::session;
 
-    let session_uuid_s = sled::IVec::from(serialize(&session_uuid.into_inner())?);
+    let session_uuid_s = sled::IVec::from(serialize(&session_uuid)?);
 
     let session = session::V {
-        category: session.category.into_inner(),
+        category: session.category,
         started: Local
             .from_local_datetime(&NaiveDateTime::parse_from_str(
                 &session.started,
@@ -145,11 +145,11 @@ pub fn edit_session(
 pub fn delete_session(
     _auth: Authorized,
     session_uuid: Uuid,
-    db: State<'_, sled::Db>,
+    db: &State<sled::Db>,
 ) -> Result<Redirect, StatusJson> {
     use crate::database::latest::trees::session;
 
-    let session_uuid_s = sled::IVec::from(serialize(&session_uuid.into_inner())?);
+    let session_uuid_s = sled::IVec::from(serialize(&session_uuid)?);
 
     let sessions_tree = db.open_tree(session::NAME)?;
 
@@ -174,7 +174,7 @@ pub fn delete_session(
 pub async fn wait_for_event(
     _auth: Authorized,
     timeout: Option<u64>,
-    event_notifier: State<'_, EventNotifier>,
+    event_notifier: &State<EventNotifier>,
 ) -> Json<WaitForEvent> {
     use std::time::Duration;
     match tokio::time::timeout(

server/src/routes/api/category.rs

@@ -3,16 +3,16 @@ use crate::database::latest::trees::category;
 use crate::status_json::StatusJson;
 use rocket::form::{Form, FromForm};
 use rocket::http::Status;
+use rocket::serde::json::Json;
+use rocket::serde::uuid::Uuid;
 use rocket::{delete, get, post, State};
-use rocket_contrib::json::Json;
-use rocket_contrib::uuid::Uuid;
 use std::collections::HashMap;
 
 #[get("/category?<include_archived>")]
 pub fn get_all(
     _auth: Authorized,
     include_archived: Option<bool>,
-    db: State<'_, sled::Db>,
+    db: &State<sled::Db>,
 ) -> Result<Json<HashMap<category::K, category::V>>, StatusJson> {
     let categories_tree = db.open_tree(category::NAME)?;
     let mut categories = category::get_all(&categories_tree)?;
@@ -26,10 +26,10 @@ pub fn get_all(
 pub fn get(
     _auth: Authorized,
     id: Uuid,
-    db: State<'_, sled::Db>,
+    db: &State<sled::Db>,
 ) -> Result<Json<category::V>, StatusJson> {
     let categories_tree = db.open_tree(category::NAME)?;
-    Ok(Json(category::get(&categories_tree, &id.into_inner())?))
+    Ok(Json(category::get(&categories_tree, &id)?))
 }
 
 #[derive(FromForm)]
@@ -43,7 +43,7 @@ pub struct NewCategory {
 pub fn create(
     _auth: Authorized,
     category: Form<NewCategory>,
-    db: State<'_, sled::Db>,
+    db: &State<sled::Db>,
 ) -> Result<StatusJson, StatusJson> {
     let category = category.into_inner();
 
@@ -68,7 +68,7 @@ pub fn create(
 pub fn remove_parent(
     _auth: Authorized,
     id: Uuid,
-    db: State<'_, sled::Db>,
+    db: &State<sled::Db>,
 ) -> Result<StatusJson, StatusJson> {
     let categories_tree = db.open_tree(category::NAME)?;
 
@@ -87,21 +87,19 @@ pub fn set_parent(
     _auth: Authorized,
     id: Uuid,
     parent_id: Json<Uuid>,
-    db: State<'_, sled::Db>,
+    db: &State<sled::Db>,
 ) -> Result<StatusJson, StatusJson> {
-    let parent_id = *parent_id.into_inner();
-
     let categories_tree = db.open_tree(category::NAME)?;
 
     // check for parent cycles
-    let mut next_parent_id = parent_id;
+    let mut next_parent_id = *parent_id;
     loop {
-        if next_parent_id == *id {
+        if next_parent_id == id {
             return Err(StatusJson::new(Status::BadRequest, "Parent cycle detected"));
         }
 
         // this also makes sure that parent exists
-        let parent = category::get(&categories_tree, &&next_parent_id)?;
+        let parent = category::get(&categories_tree, &next_parent_id)?;
 
         match parent.parent {
             Some(grandparent_id) => next_parent_id = grandparent_id,
@@ -112,7 +110,7 @@ pub fn set_parent(
     let _parent = category::get(&categories_tree, &parent_id)?;
 
     let category = category::V {
-        parent: Some(parent_id),
+        parent: Some(*parent_id),
         ..category::get(&categories_tree, &id)?
     };
 
@@ -125,7 +123,7 @@ pub fn set_parent(
 pub fn archive(
     _auth: Authorized,
     id: Uuid,
-    db: State<'_, sled::Db>,
+    db: &State<sled::Db>,
 ) -> Result<StatusJson, StatusJson> {
     let categories_tree = db.open_tree(category::NAME)?;
 
@@ -143,7 +141,7 @@ pub fn archive(
 pub fn unarchive(
     _auth: Authorized,
     id: Uuid,
-    db: State<'_, sled::Db>,
+    db: &State<sled::Db>,
 ) -> Result<StatusJson, StatusJson> {
     let categories_tree = db.open_tree(category::NAME)?;
 

server/src/routes/pages.rs

@@ -7,16 +7,17 @@ use crate::status_json::StatusJson;
 use crate::util::EventNotifier;
 use bincode::{deserialize, serialize};
 use rocket::http::Status;
+use rocket::response::content::Html;
 use rocket::response::Redirect;
+use rocket::serde::uuid::Uuid;
 use rocket::{get, post, uri, State};
-use rocket_contrib::templates::Template;
-use rocket_contrib::uuid::Uuid;
+use rocket_dyn_templates::Template;
 use serde::{Deserialize, Serialize};
 use std::collections::{BTreeMap, HashMap};
 use std::time::Duration;
 
 #[get("/")]
-pub fn index(_auth: Authorized, db: State<'_, sled::Db>) -> Result<Template, StatusJson> {
+pub fn index(_auth: Authorized, db: &State<sled::Db>) -> Result<Html<Template>, StatusJson> {
     #[derive(Debug, Serialize, Deserialize, PartialOrd, Ord, PartialEq, Eq)]
     struct Node {
         category: category::V,
@@ -89,15 +90,15 @@ pub fn index(_auth: Authorized, db: State<'_, sled::Db>) -> Result<Template, Sta
         categories: top_level_nodes,
     };
 
-    Ok(Template::render("index", &context))
+    Ok(Html(Template::render("index", &context)))
 }
 
 #[post("/category/<category_uuid>/start_session")]
 pub fn start_session(
     _auth: Authorized,
     category_uuid: Uuid,
-    event_notifier: State<'_, EventNotifier>,
-    db: State<'_, sled::Db>,
+    event_notifier: &State<EventNotifier>,
+    db: &State<sled::Db>,
 ) -> Result<Redirect, StatusJson> {
     super::api::toggle_category_session(category_uuid, true, event_notifier, db)?;
     Ok(Redirect::to(uri!(index)))
@@ -107,8 +108,8 @@ pub fn start_session(
 pub fn end_session(
     _auth: Authorized,
     category_uuid: Uuid,
-    event_notifier: State<'_, EventNotifier>,
-    db: State<'_, sled::Db>,
+    event_notifier: &State<EventNotifier>,
+    db: &State<sled::Db>,
 ) -> Result<Redirect, StatusJson> {
     super::api::toggle_category_session(category_uuid, false, event_notifier, db)?;
     Ok(Redirect::to(uri!(index)))
@@ -119,12 +120,12 @@ pub fn bump_session(
     _auth: Authorized,
     category_uuid: Uuid,
     minutes: i64,
-    db: State<'_, sled::Db>,
+    db: &State<sled::Db>,
 ) -> Result<Redirect, StatusJson> {
     use crate::database::latest::trees::category;
 
     let duration = chrono::Duration::minutes(minutes);
-    let category_uuid_s = sled::IVec::from(serialize(&category_uuid.into_inner())?);
+    let category_uuid_s = sled::IVec::from(serialize(&category_uuid)?);
 
     let categories_tree = db.open_tree(category::NAME)?;
 
@@ -162,15 +163,15 @@ pub fn bump_session(
 pub fn session_edit(
     _auth: Authorized,
     session_uuid: Uuid,
-    db: State<'_, sled::Db>,
-) -> Result<Template, StatusJson> {
+    db: &State<sled::Db>,
+) -> Result<Html<Template>, StatusJson> {
     #[derive(Debug, Serialize, Deserialize)]
     struct SessionPageContext {
         session: session::V,
         session_id: uuid::Uuid,
     }
 
-    let session_uuid_s = sled::IVec::from(serialize(&session_uuid.into_inner())?);
+    let session_uuid_s = sled::IVec::from(serialize(&session_uuid)?);
 
     let sessions_tree = db.open_tree(session::NAME)?;
     match sessions_tree.get(session_uuid_s)? {
@@ -178,16 +179,16 @@ pub fn session_edit(
         Some(data) => {
             let context = SessionPageContext {
                 session: deserialize(&data).unwrap(),
-                session_id: session_uuid.into_inner(),
+                session_id: session_uuid,
             };
 
-            Ok(Template::render("edit_session", &context))
+            Ok(Html(Template::render("edit_session", &context)))
         }
     }
 }
 
 #[get("/history")]
-pub fn history(_auth: Authorized, db: State<'_, sled::Db>) -> Result<Template, StatusJson> {
+pub fn history(_auth: Authorized, db: &State<sled::Db>) -> Result<Html<Template>, StatusJson> {
     #[derive(Debug, Serialize, Deserialize)]
     struct HistoryEntryContext {
         category: category::V,
@@ -234,5 +235,5 @@ pub fn history(_auth: Authorized, db: State<'_, sled::Db>) -> Result<Template, S
     context.entries.sort_by_key(|entry| entry.session.started);
     context.entries.reverse();
 
-    Ok(Template::render("history", &context))
+    Ok(Html(Template::render("history", &context)))
 }

server/src/routes/pages/stats.rs

@@ -4,10 +4,8 @@ use crate::status_json::StatusJson;
 use crate::util::OrdL;
 use chrono::{Date, DateTime, Datelike, Duration, Local, Timelike};
 use itertools::Itertools;
-use rocket::http::Status;
-use rocket::{get, State};
-use rocket_contrib::templates::Template;
-use rocket_contrib::uuid::Uuid;
+use rocket::{get, http::Status, response::content::Html, serde::uuid::Uuid, State};
+use rocket_dyn_templates::Template;
 use serde::{Deserialize, Serialize};
 use std::collections::{BTreeMap, HashMap, HashSet};
 
@@ -142,8 +140,8 @@ fn category_stats_ctx(
 pub fn single_stats(
     _auth: Authorized,
     category_id: Uuid,
-    db: State<'_, sled::Db>,
-) -> Result<Template, StatusJson> {
+    db: &State<sled::Db>,
+) -> Result<Html<Template>, StatusJson> {
     let categories_tree = db.open_tree(category::NAME)?;
     let sessions_tree = db.open_tree(session::NAME)?;
 
@@ -154,12 +152,12 @@ pub fn single_stats(
     let sessions: HashMap<session::K, session::V> = session::get_all(&sessions_tree)?;
 
     let now = Local::now();
-    let ctx = category_stats_ctx(now, *category_id, category, &sessions, &child_map);
-    Ok(Template::render("stats_single", dbg!(&ctx)))
+    let ctx = category_stats_ctx(now, category_id, category, &sessions, &child_map);
+    Ok(Html(Template::render("stats_single", dbg!(&ctx))))
 }
 
 #[get("/stats")]
-pub fn all_stats(_auth: Authorized, db: State<'_, sled::Db>) -> Result<Template, StatusJson> {
+pub fn all_stats(_auth: Authorized, db: &State<sled::Db>) -> Result<Html<Template>, StatusJson> {
     #[derive(Debug, Serialize, Deserialize)]
     struct StatsContext {
         categories_stats: Vec<CategoryStatsCtx>,
@@ -187,7 +185,7 @@ pub fn all_stats(_auth: Authorized, db: State<'_, sled::Db>) -> Result<Template,
 
     let context = StatsContext { categories_stats };
 
-    Ok(Template::render("stats_all", &context))
+    Ok(Html(Template::render("stats_all", &context)))
 }
 
 /// Compute the duration of `day` that is covered by the span `start..end`

server/src/routes/pages/weeks.rs

@@ -2,8 +2,8 @@ use crate::auth::Authorized;
 use crate::status_json::StatusJson;
 use chrono::{Duration, Local, NaiveDate};
 use itertools::Itertools;
-use rocket::{get, State};
-use rocket_contrib::templates::Template;
+use rocket::{get, response::content::Html, State};
+use rocket_dyn_templates::Template;
 use serde::{Deserialize, Serialize};
 use std::borrow::Cow;
 use std::iter::{once, repeat};
@@ -11,7 +11,10 @@ use std::iter::{once, repeat};
 pub struct BirthDate(pub NaiveDate);
 
 #[get("/weeks")]
-pub fn weeks(_auth: Authorized, birth_date: State<BirthDate>) -> Result<Template, StatusJson> {
+pub fn weeks(
+    _auth: Authorized,
+    birth_date: &State<BirthDate>,
+) -> Result<Html<Template>, StatusJson> {
     type Color<'a> = Cow<'a, str>;
 
     #[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
@@ -105,5 +108,5 @@ pub fn weeks(_auth: Authorized, birth_date: State<BirthDate>) -> Result<Template
             .collect(),
     };
 
-    Ok(Template::render("weeks", &context))
+    Ok(Html(Template::render("weeks", &context)))
 }

server/src/status_json.rs

@@ -4,9 +4,8 @@ use duplicate::duplicate;
 use log::{info, warn};
 use rocket::http::Status;
 use rocket::response::{Responder, Response};
+use rocket::serde::json::{json, Json};
 use rocket::Request;
-use rocket_contrib::json;
-use rocket_contrib::json::Json; // macro
 
 /// An error message which can be serialized as JSON.
 ///
@@ -81,7 +80,7 @@ impl From<T> for StatusJson {
 impl From<Status> for StatusJson {
     fn from(status: Status) -> StatusJson {
         StatusJson {
-            description: status.reason.to_string(),
+            description: status.reason().map(|r| r.to_string()).unwrap_or_default(),
             status,
         }
     }